Do not cache :spring-boot-project:spring-boot-docs:asciidoctor* tasks #34199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
|
Thanks very much, @jprinet. |
wilkinsona
pushed a commit
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal here is to document the cache misses on those 3 tasks:
:spring-boot-project:spring-boot-docs:asciidoctor:spring-boot-project:spring-boot-docs:asciidoctorMultipage:spring-boot-project:spring-boot-docs:asciidoctorPdfthe 3 task inputs
runRemoteSpringApplicationExample,runSpringApplicationExample,runLoggingFormatExampleare log files containingtimestamps,pidandabsolute path, for example:2023-02-14T15:54:42.600+01:00 INFO 61537 --- [ main] o.s.b.devtools.RemoteSpringApplication : Starting RemoteSpringApplication v3.1.0-SNAPSHOT using Java 17.0.1 with PID 61537 (/Users/myuser/.m2/repository/org/springframework/boot/spring-boot-devtools/3.1.0-SNAPSHOT/spring-boot-devtools-3.1.0-SNAPSHOT.jar started by myuser in /opt/apps/)We could consider changing the log pattern with
logging.pattern.consoleto day precision and disable logging ono.s.b.devtoolsto get a cache hit, but I assume that those outputs are part of the documentation and you want the default format / output to be displayed.In my experience the cost of having those re-running was significant: 2m 31.896s of CPU time.
This is the outcome with the cache miss documented in Gradle Enterprise:
In addition to that, naming the inputs make the troubleshooting easier in Gradle Enterprise, this is what you can get instead of anonymous
$1,$2,$3: